Skip to content

Tests: Improve isolation for randomized media tests - #13190

Draft
sirreal wants to merge 2 commits into
WordPress:trunkfrom
sirreal:agent/test-order-media-isolation
Draft

Tests: Improve isolation for randomized media tests#13190
sirreal wants to merge 2 commits into
WordPress:trunkfrom
sirreal:agent/test-order-media-isolation

Conversation

@sirreal

@sirreal sirreal commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

  • Resets loading-optimization state before each test and replaces a live crop URL with a local fixture.
  • Accepts generated caption-ID suffixes and derives expected attachment names from the files actually uploaded.
  • Restores the incoming HTTPS server value after attachment tests so a class-level fixture cannot capture leaked request state.
  • Keeps the changes confined to PHPUnit tests and fixtures.

Verification

  • Minimized seed 1789074025 to the HTTPS-mutating attachment test followed by the attachment-link class fixture, then replayed the full failing seed after the fix.
  • 100 consecutive fresh randomized media-group runs passed on the combined campaign branch after resetting the counter; each completed 842 tests and 2,220 assertions with 52 expected skips.
  • Exact seeds 1789084001 through 1789084100 all exited cleanly without exclusions or replays; maximum PHPUnit time was 33.552 seconds.
  • All three relevant changed file trees match this isolated PR branch, and the HTTPS restoration patch ID matches the gated commit.
  • PHP syntax checks and git diff --check passed.

Trac: https://core.trac.wordpress.org/ticket/65893

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant